Tidying lint warnings #1691
Tidying lint warnings #1691
Conversation
googlebot
added
the
cla: yes
| request.response | ||
| ..write('Hello, world!') | ||
| ..close(); | ||
| request.response.write('Hello, world!'); |
There was a problem hiding this comment.
Do these *_.server.dart examples need to be kept in sync with their counterparts in dart-lang/dart-tutorials-samples? Not a blocker for this PR, I'm mostly asking just to get a general sense of our approach to this right now.
See, e.g. https://github.com/dart-lang/dart-tutorials-samples/blob/master/httpserver/bin/hello_world_server.dart
(There are very slight differences between the code for these examples between dart-lang/site-www and dart-lang/dart-tutorials-samples)
There was a problem hiding this comment.
I'll create a PR for dart-lang/dart-tutorials-samples repo to bring those samples up to date. I see anagram, for example, is stuck in Dart v1.
There was a problem hiding this comment.
That took slightly longer than expected.
| ..write('Hello, world!') | ||
| ..close(); | ||
| request.response.write('Hello, world!'); | ||
| await request.response.close(); |
There was a problem hiding this comment.
There was a problem hiding this comment.
Aye, I'll do a full sweep of the tutorial samples
There was a problem hiding this comment.
Also somewhere in dart-archive/dart-tutorials-samples#49
|
I'll hold this PR open until Kathy has had a chance to review and sign off on it. |
|
I believe that #1717 will fix the build. Once that’s in, we should rerun the travis build, just to make sure… |
Should we carry out this style of fixes, or am I holding it wrong?